1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392
// Copyright (c) 2021 Metrics Contributors
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in all
// copies or substantial portions of the Software.
//! Metric recency.
//!
//! Copied from <https://github.com/metrics-rs/metrics/blob/main/metrics-util/src/registry/recency.rs>
//! Unused parts have been removed and `fn Recency::should_store` has been modified to take into
//! account of outstanding registered handles to avoid deleting them during expiry.
//!
//! THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
//! IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
//! FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
//! AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
//! LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
//! OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
//! SOFTWARE.
//!
//! `Recency` deals with the concept of removing metrics that have not been updated for a certain
//! amount of time. In some use cases, metrics are tied to specific labels which are short-lived,
//! such as labels referencing a date or a version of software. When these labels change, exporters
//! may still be emitting those older metrics which are no longer relevant. In many cases, a
//! long-lived application could continue tracking metrics such that the unique number of metrics
//! grows until a significant portion of memory is required to track them all, even if the majority
//! of them are no longer used.
//!
//! As metrics are typically backed by atomic storage, exporters don't see the individual changes to
//! a metric, and so need a way to measure if a metric has changed since the last time it was
//! observed. This could potentially be achieved by observing the value directly, but metrics like
//! gauges can be updated in such a way that their value is the same between two observations even
//! though it had actually been changed in between.
//!
//! We solve for this by tracking the generation of a metric, which represents the number of times
//! it has been modified. In doing so, we can compare the generation of a metric between
//! observations, which only ever increases monotonically. This provides a universal mechanism that
//! works for all metric types.
//!
//! `Recency` uses the generation of a metric, along with a measurement of time when a metric is
//! observed, to build a complete picture that allows deciding if a given metric has gone "idle" or
//! not, and thus whether it should actually be deleted.
use std::collections::HashMap;
use std::sync::atomic::{AtomicUsize, Ordering};
use std::sync::Arc;
use std::time::Duration;
use metrics::{atomics::AtomicU64, Counter, CounterFn, Gauge, GaugeFn, HistogramFn};
use metrics_util::{
registry::{Registry, Storage},
Hashable, MetricKind, MetricKindMask,
};
use parking_lot::Mutex;
use quanta::{Clock, Instant};
use super::storage::{AtomicF64, Histogram};
/// The generation of a metric.
///
/// Generations are opaque and are not meant to be used directly, but meant to be used as a
/// comparison amongst each other in terms of ordering.
#[derive(Clone, Copy, Debug, Eq, Ord, PartialEq, PartialOrd)]
pub(super) struct Generation(usize);
/// Generation tracking for a metric.
///
/// Holds a generic interior value, and provides way to access the value such that each access
/// increments the "generation" of the value. This provides a means to understand if the value has
/// been updated since the last time it was observed.
///
/// For example, if a gauge was observed to be X at one point in time, and then observed to be X
/// again at a later point in time, it could have changed in between the two observations. It also
/// may not have changed, and thus `Generational` provides a way to determine if either of these
/// events occurred.
#[derive(Clone)]
pub(super) struct Generational<T> {
inner: T,
gen: Arc<AtomicUsize>,
}
impl<T> Generational<T> {
/// Creates a new `Generational<T>`.
fn new(inner: T) -> Generational<T> {
Generational {
inner,
gen: Arc::new(AtomicUsize::new(0)),
}
}
/// Gets a reference to the inner value.
pub(super) fn get_inner(&self) -> &T {
&self.inner
}
/// Gets the current generation.
pub(super) fn get_generation(&self) -> Generation {
Generation(self.gen.load(Ordering::Acquire))
}
/// Acquires a reference to the inner value, and increments the generation.
pub(super) fn with_increment<F, V>(&self, f: F) -> V
where
F: Fn(&T) -> V,
{
let result = f(&self.inner);
_ = self.gen.fetch_add(1, Ordering::AcqRel);
result
}
}
impl<T> CounterFn for Generational<T>
where
T: CounterFn,
{
fn increment(&self, value: u64) {
self.with_increment(|c| c.increment(value));
}
fn absolute(&self, value: u64) {
self.with_increment(|c| c.absolute(value));
}
}
impl<T> GaugeFn for Generational<T>
where
T: GaugeFn,
{
fn increment(&self, value: f64) {
self.with_increment(|g| g.increment(value));
}
fn decrement(&self, value: f64) {
self.with_increment(|g| g.decrement(value));
}
fn set(&self, value: f64) {
self.with_increment(|g| g.set(value));
}
}
impl<T> HistogramFn for Generational<T>
where
T: HistogramFn,
{
fn record(&self, value: f64) {
self.with_increment(|h| h.record(value));
}
}
impl<T> From<Generational<T>> for Counter
where
T: CounterFn + Send + Sync + 'static,
{
fn from(inner: Generational<T>) -> Self {
Self::from_arc(Arc::new(inner))
}
}
impl<T> From<Generational<T>> for Gauge
where
T: GaugeFn + Send + Sync + 'static,
{
fn from(inner: Generational<T>) -> Self {
Self::from_arc(Arc::new(inner))
}
}
impl<T> From<Generational<T>> for metrics::Histogram
where
T: HistogramFn + Send + Sync + 'static,
{
fn from(inner: Generational<T>) -> Self {
Self::from_arc(Arc::new(inner))
}
}
/// Generational metric storage.
///
/// Tracks the "generation" of a metric, which is used to detect updates to metrics where the value
/// otherwise would not be sufficient to be used as an indicator.
pub(super) struct GenerationalStorage<S> {
inner: S,
}
impl<S> GenerationalStorage<S> {
/// Creates a new [`GenerationalStorage`].
///
/// This wraps the given `storage` and provides generational semantics on top of it.
pub(super) fn new(storage: S) -> Self {
Self { inner: storage }
}
}
impl<K, S: Storage<K>> Storage<K> for GenerationalStorage<S> {
type Counter = Generational<S::Counter>;
type Gauge = Generational<S::Gauge>;
type Histogram = Generational<S::Histogram>;
fn counter(&self, key: &K) -> Self::Counter {
Generational::new(self.inner.counter(key))
}
fn gauge(&self, key: &K) -> Self::Gauge {
Generational::new(self.inner.gauge(key))
}
fn histogram(&self, key: &K) -> Self::Histogram {
Generational::new(self.inner.histogram(key))
}
}
/// Tracks recency of metric updates by their registry generation and time.
///
/// In many cases, a user may have a long-running process where metrics are stored over time using
/// labels that change for some particular reason, leaving behind versions of that metric with
/// labels that are no longer relevant to the current process state. This can lead to cases where
/// metrics that no longer matter are still present in rendered output, adding bloat.
///
/// When coupled with [`Registry`], [`Recency`] can be used to track when the last update to a
/// metric has occurred for the purposes of removing idle metrics from the registry. In addition,
/// it will remove the value from the registry itself to reduce the aforementioned bloat.
///
/// [`Recency`] is separate from [`Registry`] specifically to avoid imposing any slowdowns when
/// tracking recency does not matter, despite their otherwise tight coupling.
pub(super) struct Recency<K> {
mask: MetricKindMask,
inner: Mutex<(Clock, HashMap<K, (Generation, Instant)>)>,
idle_timeout: Option<Duration>,
}
impl<K> Recency<K>
where
K: Clone + Eq + Hashable,
{
/// Creates a new [`Recency`].
///
/// If `idle_timeout` is `None`, no recency checking will occur. Otherwise, any metric that has
/// not been updated for longer than `idle_timeout` will be subject for deletion the next time
/// the metric is checked.
///
/// The provided `clock` is used for tracking time, while `mask` controls which metrics
/// are covered by the recency logic. For example, if `mask` only contains counters and
/// histograms, then gauges will not be considered for recency, and thus will never be deleted.
///
/// Refer to the documentation for [`MetricKindMask`](crate::MetricKindMask) for more
/// information on defining a metric kind mask.
pub(super) fn new(clock: Clock, mask: MetricKindMask, idle_timeout: Option<Duration>) -> Self {
Recency {
mask,
inner: Mutex::new((clock, HashMap::new())),
idle_timeout,
}
}
/// Checks if the given counter should be stored, based on its known recency.
///
/// If the given key has been updated recently enough, and should continue to be stored, this
/// method will return `true` and will update the last update time internally. If the given key
/// has not been updated recently enough, the key will be removed from the given registry if the
/// given generation also matches.
pub(super) fn should_store_counter<S>(
&self,
key: &K,
counter: &Generational<Arc<AtomicU64>>,
registry: &Registry<K, S>,
) -> bool
where
S: Storage<K>,
{
self.should_store(
key,
counter,
registry,
MetricKind::Counter,
Registry::delete_counter,
)
}
/// Checks if the given gauge should be stored, based on its known recency.
///
/// If the given key has been updated recently enough, and should continue to be stored, this
/// method will return `true` and will update the last update time internally. If the given key
/// has not been updated recently enough, the key will be removed from the given registry if the
/// given generation also matches.
pub(super) fn should_store_gauge<S>(
&self,
key: &K,
gauge: &Generational<Arc<AtomicF64>>,
registry: &Registry<K, S>,
) -> bool
where
S: Storage<K>,
{
self.should_store(
key,
gauge,
registry,
MetricKind::Gauge,
Registry::delete_gauge,
)
}
/// Checks if the given histogram should be stored, based on its known recency.
///
/// If the given key has been updated recently enough, and should continue to be stored, this
/// method will return `true` and will update the last update time internally. If the given key
/// has not been updated recently enough, the key will be removed from the given registry if the
/// given generation also matches.
pub(super) fn should_store_histogram<S>(
&self,
key: &K,
hist: &Generational<Arc<Histogram>>,
registry: &Registry<K, S>,
) -> bool
where
S: Storage<K>,
{
self.should_store(
key,
hist,
registry,
MetricKind::Histogram,
Registry::delete_histogram,
)
}
fn should_store<F, S, T>(
&self,
key: &K,
value: &Generational<Arc<T>>,
registry: &Registry<K, S>,
kind: MetricKind,
delete_op: F,
) -> bool
where
F: Fn(&Registry<K, S>, &K) -> bool,
S: Storage<K>,
{
let gen = value.get_generation();
if let Some(idle_timeout) = self.idle_timeout {
if self.mask.matches(kind) {
let mut guard = self.inner.lock();
let (clock, entries) = &mut *guard;
let now = clock.now();
let deleted = if let Some((last_gen, last_update)) = entries.get_mut(key) {
// If the value is the same as the latest value we have internally, and
// we're over the idle timeout period, then remove it and continue.
if *last_gen == gen {
// We don't want to delete the metric if there is an outstanding handle that
// could later update the shared value. So, here we look up the count of
// references to the inner value to see if there are more than expected.
//
// The magic value for `strong_count` below comes from:
// 1. The reference in the registry
// 2. The reference held by the value passed in here
// If there is another reference, then there is handle elsewhere.
let referenced = Arc::strong_count(&value.inner) > 2;
// If the delete returns false, that means that our generation counter is
// out-of-date, and that the metric has been updated since, so we don't
// actually want to delete it yet.
!referenced
&& (now - *last_update) > idle_timeout
&& delete_op(registry, key)
} else {
// Value has changed, so mark it such.
*last_update = now;
*last_gen = gen;
false
}
} else {
entries.insert(key.clone(), (gen, now));
false
};
if deleted {
entries.remove(key);
return false;
}
}
}
true
}
}